fix(skill): address drupal-work-on-issue gaps from issue #308#317
Merged
fix(skill): address drupal-work-on-issue gaps from issue #308#317
Conversation
Wire MergeRequestFilesResult and MergeRequestDiffResult into the formatter architecture so mr:files and mr:diff benefit from LlmFormatter (XML/CDATA output) and MarkdownFormatter alongside the existing json and text formats. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r:files and mr:diff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Step 2: check remote URL after issue:setup-remote and offer to convert HTTPS to SSH for contributors using SSH authentication - Step 3: run git diff origin/<default-branch>...HEAD before mr:list so the agent sees what the branch already contains - Step 4: run PHPCS (if available) before staging to catch style violations before they fail CI Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses three real-world gaps identified in #308 after using the
drupal-work-on-issueskill:issue:setup-remote, the skill now checks the remote URL and warns the user if it's HTTPS, offering to convert it to the SSH equivalent (git@git.drupal.org:issue/<project>-<nid>.git) for contributors using SSH authentication.git diff origin/<default-branch>...HEADas the first action, making it the authoritative source for what the branch already contains. Prevents incorrect assumptions about unchanged files.vendor/bin/phpcson the module directory (if available) before staging, blocking commits with style violations before they fail CI.Test plan
/drupal-work-on-issueon a real issue and confirm Step 2 checks/offers to convert the remote URLgit diff origin/...HEADbeforemr:listand surfaces it in the analysisvendor/bin/phpcsis presentCloses #308
🤖 Generated with Claude Code