Use container to resolve PHPStan built-in rules in tests#954
Merged
Conversation
Replaces manual construction of ImpossibleCheckTypeMethodCallRule and ImpossibleCheckTypeStaticMethodCallRule with container lookups, avoiding breakage when PHPStan adds new required constructor parameters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Same pattern as the previous fixes: avoids breakage from PHPStan constructor signature changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces manual construction of PHPStan internal rules in three test files with
self::getContainer()->getByType(...)lookups, following the pattern already established inBug825Test.AccessCheckImpossibleTypeCallRuleTest:ImpossibleCheckTypeMethodCallRuleImpossibleCheckTypeStaticMethodCallRuleTest:ImpossibleCheckTypeStaticMethodCallRuleEntityParameterTypehintRuleTest:MissingFunctionParameterTypehintRuleThis avoids
arguments.count/argument.typePHPStan errors when PHPStan adds new required constructor parameters (as happened withPossiblyImpureTipHelper).Test plan
php vendor/bin/phpunit --filter=AccessCheckImpossibleTypeCallRuleTestpassesphp vendor/bin/phpunit --filter=ImpossibleCheckTypeStaticMethodCallRuleTestpassesphp vendor/bin/phpunit --filter=EntityParameterTypehintRuleTestpassesphp vendor/bin/phpstan analyze tests/src/Rules/AccessCheckImpossibleTypeCallRuleTest.php tests/src/Rules/ImpossibleCheckTypeStaticMethodCallRuleTest.php tests/src/Rules/EntityParameterTypehintRuleTest.phpreports no errors🤖 Generated with Claude Code