fix(memory): make registerMemoryCorpusSupplement idempotent to prevent supplement loss during lazy re-register#3
Closed
mgustimz wants to merge 19 commits into
Closed
Conversation
…t supplement loss during lazy re-register
When a plugin registers a MemoryCorpusSupplement from inside api.registerService({ start }),
the supplement is correctly added to the global corpus supplements array.
However, when lazy tool-load triggers a subsequent non-activating re-register of the same
plugin, the loader snapshots the supplements BEFORE register and restores AFTER. Since the
plugin's register() call does not re-add the supplement (service.start() doesn't re-run),
the restoreMemoryPluginState() call effectively ZAPS the previously registered supplement
by overwriting the array with the pre-register snapshot.
The fix makes registerMemoryCorpusSupplement idempotent: if the plugin already has a
registered supplement, re-registering does nothing instead of wiping the existing entry.
Fixes: openclaw#77039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a plugin registers a MemoryCorpusSupplement from inside api.registerService({ start }), the supplement is correctly added to the global corpus supplements array.
However, when lazy tool-load triggers a subsequent non-activating re-register of the same plugin, the loader:
This ZAPS the previously registered supplement.
Fix
registerMemoryCorpusSupplement now checks if the plugin already has a registered supplement and skips adding a duplicate instead of replacing. This makes the registration idempotent: re-registering during lazy tool-load no longer wipes existing registrations.
Testing
Fixes openclaw#77039