Skip to content

feat: float schematic#13

Merged
mhanberg merged 7 commits intomhanberg:mainfrom
jeregrine:js/floats
May 23, 2023
Merged

feat: float schematic#13
mhanberg merged 7 commits intomhanberg:mainfrom
jeregrine:js/floats

Conversation

@jeregrine
Copy link
Copy Markdown

Is this something you want? I thought maybe decimal but it would be a new dep.

@mhanberg
Copy link
Copy Markdown
Owner

This is welcome!

Decimal can accomplished with the raw schematic.

Comment thread lib/schematic.ex Outdated
Comment thread lib/schematic.ex Outdated
Comment thread lib/schematic.ex Outdated
Comment thread lib/schematic.ex Outdated
Comment thread test/schematic_test.exs
assert {:ok, input} == unify(schematic, input)
end

test "float/0" do
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhanberg mhanberg changed the title Add floats? feat: float schematic May 10, 2023
@mhanberg
Copy link
Copy Markdown
Owner

the property tests might fail, so you can ignore it for now. I have a PR #12 to fix them.

Jason S and others added 6 commits May 10, 2023 16:47
Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>
Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>
Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>
Co-authored-by: Mitchell Hanberg <mitch@mitchellhanberg.com>
@mhanberg mhanberg merged commit 1757b05 into mhanberg:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants