fix(sheets): handle commas in appendRows cell values#125
Merged
Conversation
- Detect JSON array syntax (e.g., '["New York, NY","10001"]') for row values that contain commas - Fall back to comma-split for simple values (backward compatible) - Update help text with JSON array example Fixes #118
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #118 β
gwork sheets appendnow supports JSON array syntax for cell values containing commas.Problem
appendRowsused naiverow.split(",")which broke values like"New York, NY"into separate cells.Solution
Detect JSON array input (
[...]) and parse it; fall back to comma-split for simple values (backward compatible).Test plan
bunx tsc --noEmitβ passesbun run lintβ passesbun test --concurrentβ 256/256 tests pass