Skip to content

feat(health): Add config-aware diagnostics and align path display behavior#22

Merged
mhiro2 merged 4 commits intomainfrom
fix/path-types-health-docs-consistency
Mar 9, 2026
Merged

feat(health): Add config-aware diagnostics and align path display behavior#22
mhiro2 merged 4 commits intomainfrom
fix/path-types-health-docs-consistency

Conversation

@mhiro2
Copy link
Copy Markdown
Owner

@mhiro2 mhiro2 commented Mar 9, 2026

Summary

  • add config-aware :checkhealth diagnostics for picker backends, persistence, and tree-sitter context
  • make ui.path rendering consistent across popup titles and popup history labels
  • fix popup model annotations and correct custom provider and health documentation

Changes

  • dc2437f : fix(types): mark winid, title, win_opts as optional in PeekstackPopupModel
    • align popup model annotations with popup states where window or title metadata can be absent
  • fb8bec4 : fix(ui): apply ui.path config consistently in popup title and history
    • make popup titles respect ui.path.base and ui.path.max_width
    • make :PeekstackHistory labels use the same path rendering rules as the rest of the UI
  • e074b79 : fix(docs): correct custom provider callback signature and health section
    • correct the documented custom provider callback to include the current context argument
    • document the expanded health checks for picker backends, persistence, and tree-sitter context
  • b9fda3b : feat(health): add picker backend, persist, and tree-sitter diagnostics
    • extend :checkhealth peekstack to validate configured picker backend availability
    • report persistence setup details, including repository detection and auto-persist status
    • surface tree-sitter parser availability when title context is enabled

mhiro2 added 4 commits March 9, 2026 21:08
…Model

These fields can be nil at runtime (e.g. winid is cleared on hide,
title may not be set during popup creation, win_opts is defensively
checked with `or {}`). Align the emmylua annotations with actual behavior.
popup title now uses relative_path() with ui.path.base instead of
shorten_path(), and applies ui.path.max_width to all providers instead
of only diagnostics. :PeekstackHistory now passes path config to
display_text() for consistent path formatting across all views.
The register_provider example was missing the ctx parameter in its
callback signature. Also update the health section to document the
new picker, persist, and tree-sitter diagnostics.
Extend :checkhealth to verify that the configured picker backend plugin
is installed, report persist status and git repo detection, and check
tree-sitter parser availability when ui.title.context is enabled.
@mhiro2 mhiro2 self-assigned this Mar 9, 2026
@mhiro2 mhiro2 added the enhancement New feature or request label Mar 9, 2026
@mhiro2 mhiro2 merged commit b619649 into main Mar 9, 2026
3 checks passed
@mhiro2 mhiro2 deleted the fix/path-types-health-docs-consistency branch March 9, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant