Skip to content

refactor(core): Split config, persist, api, and popup layers#25

Merged
mhiro2 merged 4 commits intomainfrom
refactor/config-persist-api-popup
Mar 10, 2026
Merged

refactor(core): Split config, persist, api, and popup layers#25
mhiro2 merged 4 commits intomainfrom
refactor/config-persist-api-popup

Conversation

@mhiro2
Copy link
Copy Markdown
Owner

@mhiro2 mhiro2 commented Mar 10, 2026

Summary

  • Split config into defaults, shared validation helpers, and concern-specific validation rules
  • Split persist into cache, codec, and service layers, and replace placeholder persistence coverage with behavior-based specs
  • Separate top-level API setup, registry, and dispatch wiring, and break popup creation into origin, buffer, and window concerns

Changes

  • 36052c3 : refactor(config): split defaults and validation rules
    • Moved config defaults into a dedicated module and reduced peekstack.config to a thin facade
    • Split validation helpers and concern-specific rules so UI, picker, providers, and persist validation are organized by responsibility
  • 813a8a1 : refactor(persist): split service layers and strengthen specs
    • Extracted persistence cache, codec, and service responsibilities to make save and restore flows easier to follow
    • Reworked persistence specs to assert real save/restore/list/delete/max_items behavior using actual popup data instead of placeholder checks
  • 8eb3726 : refactor(api): split setup and dispatch wiring
    • Moved provider and picker registry, highlight setup, setup flow, and dispatch logic out of peekstack.init
    • Kept the public API intact while making peekstack.init focus on API wiring
  • d5a3e27 : refactor(popup): isolate origin buffer and window setup
    • Split popup creation into origin capture, buffer preparation, and window opening concerns
    • Added focused tests for popup origin detection and buffer preparation so the new internal boundaries are directly covered

@mhiro2 mhiro2 self-assigned this Mar 10, 2026
@mhiro2 mhiro2 merged commit b361af5 into main Mar 10, 2026
3 checks passed
@mhiro2 mhiro2 deleted the refactor/config-persist-api-popup branch March 10, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant