Conversation
Delegate stack_view.window.find_root_winid() to core.stack.get_root_winid() to eliminate duplicated root window resolution logic. The core version additionally checks the popup index and peekstack_root_winid window variable, which fixes incorrect root detection when opening stack view from a popup in a multi-split layout.
…ld links Save the original popup_id in history entries and use it to build an old-to-new ID mapping during restore_all. This ensures that parent_popup_id references point to the correct newly-created popup IDs rather than stale ones from before the close.
…ssions Extend session items to include popup_id, pinned, buffer_mode, and parent_popup_id so that restored sessions faithfully reproduce the original exploration flow. Parent IDs are remapped during restore to point to newly created popup IDs.
Add validation rules for previously unchecked config fields:
- providers.{lsp,diagnostics,file}.enable
- providers.marks.enable
- persist.enabled
- ui.popup.auto_close.{enabled,idle_ms,check_interval_ms,ignore_pinned}
- ui.feedback.highlight_origin_on_close
- ui.promote.close_popup
- ui.title.{enabled,format}
- ui.title.context.{enabled,max_depth,separator}
Invalid values (e.g. string "false" for booleans) now warn and
fall back to defaults instead of silently being treated as truthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
core.stack.get_root_winid()and removed duplicated lookup logicpopup_idin history entries and rebuiltparent_popup_idreferences through an old-to-new ID remap during restorepopup_id,pinned,buffer_mode, andparent_popup_idso saved sessions reproduce the original exploration state more faithfullyproviders.*.enable,persist.enabled,ui.popup.auto_close, andui.title