Skip to content

fix(core): Clarify persist behavior and harden grep and quick peek cleanup#27

Merged
mhiro2 merged 5 commits intomainfrom
fix/persist-grep-stack-notify
Mar 19, 2026
Merged

fix(core): Clarify persist behavior and harden grep and quick peek cleanup#27
mhiro2 merged 5 commits intomainfrom
fix/persist-grep-stack-notify

Conversation

@mhiro2
Copy link
Copy Markdown
Owner

@mhiro2 mhiro2 commented Mar 19, 2026

Summary

  • Clarify persistence fallback behavior and repeated setup expectations in the documentation
  • Route Telescope extension warnings through the shared peekstack notification helper
  • Improve grep failure messaging for ignore-file related errors and add regression coverage
  • Limit quick peek auto-close to the active root window and preserve history/events on wipeout paths

Changes

  • f189723 : docs(setup): clarify persist fallback and reload behavior
    • Clarified that persistence uses repository storage inside a git repository and falls back to cwd-based
      storage outside it
    • Documented what repeated setup() calls re-register and what existing popups, stacks, and history are
      not migrated in place
  • 70c25a0 : fix(extension): use peekstack notify for telescope warnings
    • Unified Telescope extension warnings with the shared notification helper so warning formatting stays
      consistent with the rest of the plugin
  • 091924d : fix(grep): explain ignore file failures
    • Added targeted warning messages for ripgrep failures that likely come from .gitignore, .ignore, or
      .rgignore issues
    • Added regression tests for failure-message formatting and the warning path used by grep.search
  • e875c6d : fix(stack): scope quick peek closes and preserve wipeout history
    • Scoped quick peek auto-close handling to the active root window so unrelated ephemeral popups are not
      closed across splits
    • Preserved PeekstackClose, PeekstackHistoryPush, and history entries when popups are removed through
      buffer or origin wipeout paths
    • Added regression tests for multi-window quick peek cleanup and wipeout event/history handling
  • 31bbbf7 : test(grep): stub rg availability in failure spec
    • Removed the grep failure spec's dependency on the real rg executable so the ignore-file warning path is
      exercised consistently in CI

@mhiro2 mhiro2 self-assigned this Mar 19, 2026
@mhiro2 mhiro2 added the bug Something isn't working label Mar 19, 2026
@mhiro2 mhiro2 merged commit 15b8299 into main Mar 19, 2026
3 checks passed
@mhiro2 mhiro2 deleted the fix/persist-grep-stack-notify branch March 19, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant