Merged
Conversation
Warn and fall back to defaults when setup() receives a non-table value, preventing vim.tbl_deep_extend from raising on truthy scalars like booleans or strings.
Call cb({}) when no LSP clients are attached or when
vim.lsp.get_clients returns nil so consumers can rely on
the provider contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup(opts)from crashing on non-table inputs by falling back to defaults with a warningChanges
setup(opts)against truthy non-table values (booleans, strings, numbers) that previously crashedvim.tbl_deep_extend, falling back to defaults with a warningtests/config_spec.luacb({})when no LSP clients are attached or whenvim.lsp.get_clientsreturns nil, so consumers can rely on the provider contracttests/lsp_provider_spec.lua