Prefix role variable names #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringods
reviewed
Jul 13, 2018
ringods
left a comment
ringods
left a comment
There was a problem hiding this comment.
After renaming all my vars, I got this error at execution:
fatal: [10.130.20.211]: FAILED! => {"msg": "The conditional check 'docker_pull' failed. The error was: error while evaluating conditional (docker_pull): 'docker_pull' is undefined\n\nThe error appears to have been in '/Users/ringods/.ansible/roles/ansible-docker-systemd-service/tasks/install.yml': line 12, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# use `command` instead of `docker_image` so we don't have to install docker-py\n- name: Pull image {{ container_image }}\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be written as:\n\n with_items:\n - \"{{ foo }}\"\n"}
| * `link` (default: _[]_) - List of `--link` arguments | ||
| * `labels` (default: _[]_) - List of `-l` arguments | ||
| * `docker_pull` (default: _yes_) - whether the docker image should be pulled | ||
| * `container_env` - key/value pairs of ENV vars that need to be present |
There was a problem hiding this comment.
In the template env.j2, you don't check whether container_env is set. I noticed this because I forgot to rename env to container_env.
Owner
Author
|
Updated README to reflect new var names and new syntax; I think the usage example was not updated since 1.0 |
|
@mhutter have you also seen the error I reported? See above. |
The current implementation uses some quite generic variable names, such as `state`. As role defaults have the lowest priority when it comes to variable precedence, they are easily overwritten. This is a breaking change! Fixes #2
Owner
Author
|
@ringods I have, I even fixed it but did not commit it before pushing 🤦♂️ Fixed now, please check again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses some quite generic variable names, such
as
state. As role defaults have the lowest priority when it comes tovariable precedence, they are easily overwritten.
This is a breaking change!
Fixes #2