-
Notifications
You must be signed in to change notification settings - Fork 49
1970 playground select, side nav and section container #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1970 playground select, side nav and section container #1989
Conversation
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1970-playground-select-and-side-nav/web-components |
7a6962d to
7995fff
Compare
|
Cypress visual tests failed. |
7995fff to
58617e5
Compare
|
found a slight issue in the select playgrounds: if you set loading to true, then back to false, it doesn't clear & you can no longer see the options |
58617e5 to
789bf1d
Compare
I've found the issue I think - the loadingHandler function doesn't consider leaving loading... @Watch("loading")
loadingHandler(newValue: boolean): void {
newValue && this.triggerLoading();
}Raised a ticket for this: #2003 |
Add size buttons to searchable and single select storybooks
Added a playground storybook for sidenav in react ref 1970
If aligned prop set to null after first render, now section container will update
Add Playground storybook in react for section-container ref 1970
789bf1d to
4671a2e
Compare
Summary of the changes
Add Storybook playgrounds for Select, SideNav and Section Container
Small fix to Section Container for when you change 'aligned' prop to null after first render (as what happens in the storybook)
Related issue
#1970