Skip to content

Conversation

@GCHQ-Developer-299
Copy link
Contributor

Summary of the changes

Add Storybook playgrounds for Select, SideNav and Section Container
Small fix to Section Container for when you change 'aligned' prop to null after first render (as what happens in the storybook)

Related issue

#1970

@github-actions
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 force-pushed the 1970-playground-select-and-side-nav branch 2 times, most recently from 7a6962d to 7995fff Compare June 13, 2024 10:47
@github-actions
Copy link
Contributor

@GCHQ-Developer-299 GCHQ-Developer-299 force-pushed the 1970-playground-select-and-side-nav branch from 7995fff to 58617e5 Compare June 14, 2024 07:58
@GCHQ-Developer-530 GCHQ-Developer-530 linked an issue Jun 14, 2024 that may be closed by this pull request
40 tasks
@ad9242
Copy link
Collaborator

ad9242 commented Jun 14, 2024

found a slight issue in the select playgrounds: if you set loading to true, then back to false, it doesn't clear & you can no longer see the options

@GCHQ-Developer-299 GCHQ-Developer-299 force-pushed the 1970-playground-select-and-side-nav branch from 58617e5 to 789bf1d Compare June 14, 2024 13:39
@GCHQ-Developer-299
Copy link
Contributor Author

GCHQ-Developer-299 commented Jun 14, 2024

found a slight issue in the select playgrounds: if you set loading to true, then back to false, it doesn't clear & you can no longer see the options

I've found the issue I think - the loadingHandler function doesn't consider leaving loading...

  @Watch("loading")
  loadingHandler(newValue: boolean): void {
    newValue && this.triggerLoading();
  }

Raised a ticket for this: #2003

Add size buttons to searchable and single select storybooks
Added a playground storybook for sidenav in react

ref 1970
If aligned prop set to null after first render, now section container will update
Add Playground storybook in react for section-container

ref 1970
@gd2910 gd2910 force-pushed the 1970-playground-select-and-side-nav branch from 789bf1d to 4671a2e Compare June 17, 2024 14:06
@GCHQ-Developer-530 GCHQ-Developer-530 merged commit 2edf293 into develop Jun 18, 2024
@GCHQ-Developer-530 GCHQ-Developer-530 deleted the 1970-playground-select-and-side-nav branch June 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add props playground to each component and test all combinations

5 participants