Set default PAGE_SIZE for Api in __init__ (#64) #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the default value of PAGE_SIZE for the Api object when it is initialized using a Flask app (as it is in current documentation examples).
Collaborator
|
I can't merge this PR until continuous integration test fails. Please fix tests if you want to include this fix soon. |
|
I adjusted Api's init to create a default Flask object if no app is provided. |
hellupline
reviewed
Nov 16, 2017
| """ | ||
|
|
||
| if app is None: | ||
| app = Flask(__name__) |
Contributor
There was a problem hiding this comment.
I dont think this is a good idea:
If the user create a instance of the jsonapi, then configure it using self.init_app(app):
the user would have created a second Flask app,
instead, __init__ shoud try to call init_app if app is not None.
also, calling init_app on __init__ would solve the first issue, to set default PAGE_SIZE
Contributor
Author
|
Thanks, @hellupline. Closing this as irrelevant now based on your new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default value of PAGE_SIZE for the Api object when it is initialized using a Flask app (as it is in current documentation examples).