Skip to content

Set default PAGE_SIZE for Api in __init__ (#64) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcampbell wants to merge 2 commits into from
Closed

Set default PAGE_SIZE for Api in __init__ (#64) #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1d774
Set default PAGE_SIZE for Api in __init__ (#64)
jcampbell Oct 25, 2017
752052d
Add default Flask app in Api __init__ if no app is provided.
jcampbell Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flask_rest_jsonapi/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import inspect
from functools import wraps

from flask import Flask
from flask_rest_jsonapi.resource import ResourceList


Expand All @@ -20,12 +21,19 @@ def __init__(self, app=None, blueprint=None, decorators=None):
:param blueprint: a flask blueprint
:param tuple decorators: a tuple of decorators plugged to each resource methods
"""

if app is None:
app = Flask(__name__)
Copy link
Contributor

@hellupline hellupline Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is a good idea:

If the user create a instance of the jsonapi, then configure it using self.init_app(app):
the user would have created a second Flask app,

instead, __init__ shoud try to call init_app if app is not None.
also, calling init_app on __init__ would solve the first issue, to set default PAGE_SIZE


self.app = app
self.blueprint = blueprint
self.resources = []
self.resource_registry = []
self.decorators = decorators or tuple()

self.app.config.setdefault('PAGE_SIZE', 30)


def init_app(self, app=None, blueprint=None):
"""Update flask application with our api

Expand Down