Include a textual message in HTTP response status line (As recommended by RFC) #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry but it changes to much things all responses will be affected and i have fear of side effects so i will close this pr. |
|
There is a better way. The problem is that statuses in JsonApiException are strings instead of integers. Flask does the job of adding the text if the status is an integer. I can create a pull request if akira-dev agrees with that solution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP responses that are returned, when exceptions are raised, should include a textual message after http status code. They are not required by RFC, but it's recommended to include them.
Missing message may also break some HTTP clients.
So instead of:
HTTP/1.1 404Json api will return
HTTP/1.1 404 Object not foundetc.