Skip to content

fix(ci): revert to non-draft releases to preserve release notes#719

Merged
cpcloud merged 1 commit intomainfrom
worktree-rippling-swimming-tower
Mar 8, 2026
Merged

fix(ci): revert to non-draft releases to preserve release notes#719
cpcloud merged 1 commit intomainfrom
worktree-rippling-swimming-tower

Conversation

@cpcloud
Copy link
Copy Markdown
Collaborator

@cpcloud cpcloud commented Mar 8, 2026

Summary

  • GoReleaser's keep-existing mode wipes the release body on draft releases, replacing semantic-release's notes with an empty body
  • Revert to non-draft releases: semantic-release creates a published release with notes, release: [created] fires, GoReleaser adds artifacts without touching the body
  • Remove the workflow_call plumbing from CI (no longer needed)
  • Keep workflow_dispatch for manual re-releases

closes #715

@cpcloud cpcloud force-pushed the worktree-rippling-swimming-tower branch from e79eac4 to 56b8f2c Compare March 8, 2026 23:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (8f7cb55) to head (3c3abed).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

semantic-release creates the GitHub release with notes, so making it a
draft and then publishing separately loses the notes. Trigger the release
workflow on the `release: created` event instead of calling it directly
from CI, and remove the draft/publish dance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cpcloud cpcloud force-pushed the worktree-rippling-swimming-tower branch from 56b8f2c to 3c3abed Compare March 8, 2026 23:24
@cpcloud cpcloud merged commit 0c22d7a into main Mar 8, 2026
15 checks passed
@cpcloud cpcloud deleted the worktree-rippling-swimming-tower branch March 8, 2026 23:25
cpcloud added a commit that referenced this pull request Mar 19, 2026
## Summary

- GoReleaser's `keep-existing` mode wipes the release body on draft
releases, replacing semantic-release's notes with an empty body
- Revert to non-draft releases: semantic-release creates a published
release with notes, `release: [created]` fires, GoReleaser adds
artifacts without touching the body
- Remove the `workflow_call` plumbing from CI (no longer needed)
- Keep `workflow_dispatch` for manual re-releases

closes #715

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): draft releases never publish — release.yml uses ignored trigger

1 participant