fix(documents): default file picker to cwd, not ~/Downloads#952
Merged
cpcloud merged 1 commit intomicasa-dev:mainfrom Apr 18, 2026
Merged
fix(documents): default file picker to cwd, not ~/Downloads#952cpcloud merged 1 commit intomicasa-dev:mainfrom
cpcloud merged 1 commit intomicasa-dev:mainfrom
Conversation
cpcloud
added
bug
The document file picker defaulted to the system Downloads folder via `xdg.UserDirs.Download`. That's non-deterministic — demos, tapes, and tutorials would pick up whatever happens to sit at the top of the recorder's real Downloads, producing non-reproducible captures and risking PII leaks in committed demo videos. Default to the current working directory instead. Explicit `documents.file_picker_dir` / `MICASA_DOCUMENTS_FILE_PICKER_DIR` still wins. Users who want Downloads as the starting location set it explicitly.
cpcloud
force-pushed
the
worktree-demo-picker-cwd
branch
from
b5b442c to
ddbba69
Compare
cpcloud
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfg.Documents.ResolvedFilePickerDir(), which defaulted toxdg.UserDirs.Downloadwhen unconfigured. That's non-deterministic — demos, tapes, and tutorials pressingEnterin the picker would select whatever sits at the top of the recorder's real~/Downloads, producing irreproducible captures and a PII-leak risk for committed demo videos.documents.file_picker_dir/MICASA_DOCUMENTS_FILE_PICKER_DIRstill wins. Users who prefer Downloads as the starting location set it explicitly.Reproduction steps
~/Downloads.micasa(ormicasa demo), go to Docs tab, pressithenA.~/DownloadsandEnterselects the first file there.On this branch, step 3 opens the picker in the dir
micasawas launched from.