docs(agents): forbid reinventing stdlib helpers and nil-passing#964
Merged
cpcloud merged 1 commit intomicasa-dev:mainfrom Apr 20, 2026
Merged
docs(agents): forbid reinventing stdlib helpers and nil-passing#964cpcloud merged 1 commit intomicasa-dev:mainfrom
cpcloud merged 1 commit intomicasa-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two new rules in
AGENTS.mdunder the "Architecture and code style" hard rules, both triggered by real incidents during recent eval-harness work:boolStr,max,min, "convert primitive to string", "first non-zero value"). Go 1.21+ builtinmin/max,strconv.FormatBool/FormatInt,slices.Contains,maps.Keys,cmp.Or— the stdlib covers most of these. A helper that reimplements stdlib adds surface area, hides the standard name, and tells reviewers "I didn't look."nil,"",0) to a third-party function, read its godoc or grep for other call sites. Functions that query the terminal, open files, or dial the network commonly dereference their arguments.lipgloss.HasDarkBackground(os.Stdin, os.Stderr)— not(nil, nil). "I'll pass nil and see" is a red flag.No code change.