Skip to content

🧹 Resolve PR #24 code review comments & bump to v2.0.0#25

Merged
miccy merged 1 commit intodev/preview-v2from
fix-pr-24-comments-8055072161225754820
May 5, 2026
Merged

🧹 Resolve PR #24 code review comments & bump to v2.0.0#25
miccy merged 1 commit intodev/preview-v2from
fix-pr-24-comments-8055072161225754820

Conversation

@miccy
Copy link
Copy Markdown
Owner

@miccy miccy commented May 5, 2026

This PR addresses all outstanding feedback and code review comments from PR #24 to finalize the release of version 2.0.0.

Key changes:

  • Added validatePath usage and updated source mapping to correctly track lockfile origins across bun.ts, yarn.ts, pnpm.ts, and requirements.ts.
  • Implemented a proper string-aware stripJsonc logic in the Bun lockfile parser to robustly handle JSONC comments and trailing commas natively without failing.
  • Handled errors properly for readdirSync in cli.ts's threat loader to prevent unexpected crashes due to missing or unreadable directories.
  • Updated tool version fields everywhere (in SARIF output format and Wiki Sync headers) to explicitly declare v2.0.0.
  • Reformatted TypeScript imports across the scanner/engine test files to align with Biome's rules and removed unwanted usage of any.
  • Adjusted parseLockfiles to correctly handle asynchronous Python requirements.txt discovery by returning a Promise and updating down the line logic in detectors/index.ts.
  • Included peerDependencies and optionalDependencies logic to the injection detectors to avoid false positives on legitimate peer dependencies.
  • Fixed an invalid URL in the renovate-defense.json anti-worm template.
  • Ensured apps/docs/playwright.config.ts matches both .spec.ts and .e2e.ts.

PR created automatically by Jules for task 8055072161225754820 started by @miccy

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 564653bf-9915-4c78-b5e2-73de689d6875

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pr-24-comments-8055072161225754820

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy marked this pull request as ready for review May 5, 2026 03:39
@miccy miccy merged commit dc4a108 into dev/preview-v2 May 5, 2026
5 checks passed
@miccy miccy deleted the fix-pr-24-comments-8055072161225754820 branch May 5, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant