Conversation
WalkthroughUpdates version identifiers to 1.3.3 across multiple shell scripts, adds a new 1.3.3 section to CHANGELOG.md while removing one bullet from the 1.3.2 entry, and adjusts configuration and AI assistant guidance in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (5)📓 Common learnings📚 Learning: 2025-11-30T14:28:26.180ZApplied to files:
📚 Learning: 2025-11-30T14:28:13.600ZApplied to files:
📚 Learning: 2025-11-30T14:28:13.600ZApplied to files:
📚 Learning: 2025-11-30T14:28:13.600ZApplied to files:
🔇 Additional comments (2)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
scripts/detect.sh (1)
70-99: Trap and output file handling are well-implemented.The cleanup logic is solid:
- Pre-creates output file so CI artifacts can upload even on early exit
- Trap ensures summary is always appended (normal or error exits)
- Gracefully handles missing OUTPUT_FILE
Consider adding a brief inline comment explaining the trap's purpose for maintainability.
CHANGELOG.md (1)
1-7: Consider updating PR description to reflect actual changes.The PR title indicates "chore: release v1.3.3," but the PR body shows an unfilled template with a changelog placeholder. For clarity and traceability, consider filling in the PR description with a summary of what's included in this release (version bumps, detect.sh enhancements, CHANGELOG updates, etc.).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
CHANGELOG.md(1 hunks)scripts/check-github-repos.sh(1 hunks)scripts/detect.sh(1 hunks)scripts/full-audit.sh(1 hunks)scripts/harden-npm.sh(1 hunks)scripts/quick-audit.sh(1 hunks)scripts/set-language.sh(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.sh
📄 CodeRabbit inference engine (AGENTS.md)
**/*.sh: Use English comments only in shell script files (.sh)
Use shellcheck for validation of all shell script modifications
Files:
scripts/quick-audit.shscripts/check-github-repos.shscripts/harden-npm.shscripts/set-language.shscripts/full-audit.shscripts/detect.sh
scripts/**/*.sh
📄 CodeRabbit inference engine (AGENTS.md)
scripts/**/*.sh: Scripts must be tested for compatibility with both macOS and Linux before suggesting modifications
Maintain safety checks in all detection scripts and never auto-run security scripts without explicit user confirmation
All detection scripts must include documentation inDETECTION.mdand updates toCHANGELOG.md
Files:
scripts/quick-audit.shscripts/check-github-repos.shscripts/harden-npm.shscripts/set-language.shscripts/full-audit.shscripts/detect.sh
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/scripts/**/*.sh : Breaking changes to public script APIs must not be made without proper versioning and migration documentation
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to scripts/**/*.sh : All detection scripts must include documentation in `DETECTION.md` and updates to `CHANGELOG.md`
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/scripts/**/*.sh : Breaking changes to public script APIs must not be made without proper versioning and migration documentation
Applied to files:
scripts/quick-audit.shscripts/harden-npm.shscripts/full-audit.shscripts/detect.sh
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to scripts/**/*.sh : All detection scripts must include documentation in `DETECTION.md` and updates to `CHANGELOG.md`
Applied to files:
scripts/detect.shCHANGELOG.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/**/CHANGELOG.md : CHANGELOG.md must be updated when detekční logika is added or modified
Applied to files:
CHANGELOG.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Prioritize changes in order: critical security updates (new IOCs, vulnerability fixes), broken functionality, documentation accuracy, enhancements, then style/formatting
Applied to files:
CHANGELOG.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to scripts/**/*.sh : Maintain safety checks in all detection scripts and never auto-run security scripts without explicit user confirmation
Applied to files:
CHANGELOG.md
🔇 Additional comments (6)
scripts/set-language.sh (1)
2-2: Version bump looks good.Consistent version update across the release. The script correctly exposes this via the
--versionflag.scripts/quick-audit.sh (1)
2-2: Version bump approved. Verify DETECTION.md was updated.The version bump is consistent. However, per coding guidelines, detection scripts require documentation updates. Please confirm that
DETECTION.mdandcs/docs/DETECTION.md(if applicable) have been updated to reflect any changes to this audit script.scripts/full-audit.sh (1)
20-20: Version bump approved. Verify DETECTION.md was updated.Version is consistent with the release. Please confirm that documentation in
DETECTION.mdhas been updated to reflect this audit script's capabilities.scripts/check-github-repos.sh (1)
2-2: Version bump approved. Verify DETECTION.md was updated.Version is consistent with the release. Please ensure that
DETECTION.mddocumentation reflects any GitHub-specific detection capabilities in this script.scripts/detect.sh (1)
26-26: Version bump approved, but functional changes need CHANGELOG documentation.The version bump is consistent. However, lines 70–99 contain significant functional additions (OUTPUT_FILE handling for CI, trap setup for summary generation on exit) that should be documented in
CHANGELOG.mdunder the 1.3.3 section.The AI summary states "no functional modifications," but this file includes:
- Output file path normalization for CI environments (lines 72–81)
- Exit trap to write scan summary (lines 84–98)
Please confirm these changes are intentional for this release and update the CHANGELOG accordingly.
scripts/harden-npm.sh (1)
2-2: Version bump approved.Consistent version update. The script maintains good safety practices with dry-run mode as default.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Miccy <code@miccy.dev>
…Commits auto-titling, and add documentation guidelines for changelog and bilingual content.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.coderabbit.yaml(2 hunks)AGENTS.md(1 hunks)CHANGELOG.md(1 hunks)cs/AGENTS.md(1 hunks)
🧰 Additional context used
🧠 Learnings (16)
📓 Common learnings
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/scripts/**/*.sh : Breaking changes to public script APIs must not be made without proper versioning and migration documentation
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/**/CHANGELOG.md : CHANGELOG.md must be updated when detekční logika is added or modified
Applied to files:
cs/AGENTS.mdCHANGELOG.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/docs/**/*.md : All .md files in docs/ directory must maintain feature parity between English and Czech versions
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/**/{CONTRIBUTING.md,CONTRIBUTING-cs.md} : CONTRIBUTING guides must exist in both English (CONTRIBUTING.md) and Czech (CONTRIBUTING-cs.md) versions
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Documentation updates affecting both English and Czech versions must be synchronized in commits using scopes: `docs(en)`, `docs(cs)`, or `docs(all)`
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/{README.md,cs/README.md} : Root README files must exist in both English (README.md) and Czech (cs/README.md) versions with identical feature parity
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to README.md : Root README files must maintain bilingual support with `README.md` for English and `cs/README.md` for Czech versions
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/docs/**/*.md : Documentation updates must include commit message scope indicating affected language(s): 'docs(en)', 'docs(cs)', or 'docs(all)'
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: When updating documentation, both English and Czech versions must be updated simultaneously to maintain feature parity
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/docs/**/*.md : Technical terms (CVE, IOC, etc.) must remain in English in both Czech and English language documentation
Applied to files:
cs/AGENTS.md
📚 Learning: 2025-11-30T14:28:26.180Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: cs/AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:26.180Z
Learning: Applies to cs/docs/**/*.md : Code examples in documentation must be identical across both English and Czech versions
Applied to files:
cs/AGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to docs/**/*.md : All `.md` files in `docs/` must have both English (EN) and Czech (CS) versions with identical content structure and identical code examples
Applied to files:
cs/AGENTS.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to docs/**/*.md : Technical terms (CVE, IOC, etc.) must remain in English in both English and Czech versions of documentation
Applied to files:
cs/AGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to scripts/**/*.sh : All detection scripts must include documentation in `DETECTION.md` and updates to `CHANGELOG.md`
Applied to files:
CHANGELOG.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Prioritize changes in order: critical security updates (new IOCs, vulnerability fixes), broken functionality, documentation accuracy, enhancements, then style/formatting
Applied to files:
CHANGELOG.mdAGENTS.md
📚 Learning: 2025-11-30T14:28:13.600Z
Learnt from: CR
Repo: miccy/dont-be-shy-hulud PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-30T14:28:13.600Z
Learning: Applies to scripts/**/*.sh : Maintain safety checks in all detection scripts and never auto-run security scripts without explicit user confirmation
Applied to files:
CHANGELOG.md
🔇 Additional comments (3)
CHANGELOG.md (1)
8-24: ✅ Past review concern resolved—detect.sh enhancements now documented.The 1.3.3 section now properly includes the detect.sh output handling enhancement (line 18) that was flagged as missing in the previous review. The changelog entries align with the broader PR changes and follow the Keep a Changelog format correctly.
cs/AGENTS.md (1)
105-114: ✅ Bilingual guidelines properly formalized in Czech.The new sections on Changelog Updates (lines 105–108) and Bilingual Documentation Rule (lines 110–113) clearly codify the maintenance requirements. These guidelines align with the learnings documented for this repository and provide clear expectations for contributors. As per learnings, both English and Czech versions must be synchronized, and the corresponding English version (AGENTS.md) mirrors these guidelines appropriately.
AGENTS.md (1)
103-111: ✅ Bilingual guidelines properly formalized in English.The new Changelog Updates section (lines 103–106) and Bilingual Documentation Rule (lines 108–111) codify essential maintenance practices. These guidelines align with the PR objectives and formalize documented learnings about keeping English and Czech versions synchronized while maintaining changelog discipline.
…proval upon issue resolution.
…coderabbit.yaml` and updated the changelog.
Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Changelog
[1.3.3] - 2025-11-30
Added
CHANGELOG.mdinrelease.ymlChanged
scripts/release.shto support releases from*-devbranches (e.g.,claude-dev,gemini-dev)docs/RELEASE_WORKFLOW.mdandcs/docs/RELEASE_WORKFLOW.mdto reflect*-devbranch supportFixed
.coderabbit.yamlconfigurationType of change
Checklist:
Summary by CodeRabbit
Chores
Chores / Configuration
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.