New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping the last (grouped) item won't drop the storage from the session #67

Closed
michael-e opened this Issue Jan 23, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@michael-e
Owner

michael-e commented Jan 23, 2018

Storage attempts to clean up session data when items are dropped: Storage::drop will unset an empty storage array. However, the group will always remain in the storage array even after the last item has been dropped from the group. So the cleanup will not work as expected.

The solution is to make Storage::drop clean up recursively:

  • Drop item
  • Unset empty groups
  • Unset empty storage

I will push the fix soon.

@michael-e michael-e added the bug label Jan 23, 2018

@michael-e michael-e self-assigned this Jan 23, 2018

@michael-e michael-e closed this in 472aae3 Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment