Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the service commands for Matterbridge across multiple platforms, adds new install options for frontend port and SSL, and bumps the version to v0.4.0.
- Modified method signatures in platform, macOS, and Linux implementations to accept extra arguments.
- Updated sudoers configuration and improved test workflow commands.
- Adjusted documentation and package version accordingly.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/platform.ts | Updated abstract methods to accept args, added user info and mkdir helper |
| src/mb-service.ts | Introduced new install options and updated command handling |
| src/mac.ts | Adjusted install signature and refactored private methods to use shared helpers |
| src/linux.ts | Similar refactoring as macOS; updated sudoers file configuration |
| package.json | Bumped version from 0.3.0 to 0.4.0 |
| README.md | Updated option descriptions and usage examples |
| .github/workflows/test.yml | Added chmod on sudoers and tests for updated install options |
Comments suppressed due to low confidence (1)
src/linux.ts:103
- [nitpick] Review if overwriting or creating a new sudoers file might conflict with existing configuration. Consider checking for an existing sudoers entry and appending instead of replacing it if necessary.
chmodSync(sudoersPath, 0o440);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.