Vision fix for non-clip models#439
Merged
michaelfeil merged 3 commits intomainfrom Oct 23, 2024
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
This PR enhances the TIMM class in torch_vision.py for improved compatibility and performance with various vision model types, accompanied by corresponding updates to the test suite.
- Modified
encode_coremethod inTIMMclass to handle different processing paths based onis_colipaliflag - Updated
tokenize_lengthsmethod to ensure correct data types for input tensors - Introduced parameterization in
test_clip_like_modelfunction to test multiple model types - Replaced specific CLIP imports with generic AutoModel and AutoProcessor in test file
- Updated main block in test file to use new image sample URL and test both CLIP-like and ColPali models
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
- Coverage 79.22% 79.18% -0.05%
==========================================
Files 41 41
Lines 3245 3248 +3
==========================================
+ Hits 2571 2572 +1
- Misses 674 676 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437