Add PR template (With changes)#441
Conversation
There was a problem hiding this comment.
PR Summary
This PR adds comprehensive issue and pull request templates to standardize contribution formats, including bug reports, feature requests, model additions, and general pull requests.
- Added
.github/pull_request_template.mdwith structured sections for description, changes, and MIT license confirmation - Added
.github/ISSUE_TEMPLATE/bug-report.ymlwith detailed system info collection and reproduction steps - Added
.github/ISSUE_TEMPLATE/feature-request.ymlfor capturing feature proposals and motivation - Added
.github/ISSUE_TEMPLATE/new-model-addition.ymlspecifically for model implementation requests - Added
.github/ISSUE_TEMPLATE/config.ymlto enable blank issues alongside templates
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| - [ ] Documentation update | ||
|
|
||
| ## Checklist | ||
| - [ ] I have read the [CONTRIBUTING](https://github.com/michaelfeil/infinity/tree/main?tab=readme-ov-file#contribute-and-develop) guidelines. |
There was a problem hiding this comment.
style: The CONTRIBUTING link points to the readme tab which may break. Consider using direct link to contribution.md instead
| - [ ] I have added tests to cover my changes. | ||
| - [ ] All new and existing tests passed. |
There was a problem hiding this comment.
style: Consider adding '(if applicable)' to test-related items since some changes (like docs) don't need tests
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 41 41
Lines 3248 3248
=======================================
Hits 2572 2572
Misses 676 676 ☔ View full report in Codecov by Sentry. |
Description
This PR adds new pull request and issue templates to project. The templates provide structured guidelines for contributors, ensuring that necessary information is included in PRs.
I had already opened a PR for same, but it had some issues. Now I have implemented changes suggested by @wirthual in current PR.
Old Pull Request
#417
Related Issue
#416
Type of Change
Checklist
License
By submitting this PR, I confirm that my contribution is made under the terms of the MIT license.