Add .gitattributes to .gitignore#22
Merged
michaelkourlas merged 1 commit intomichaelkourlas:masterfrom Dec 17, 2014
Merged
Conversation
The file is already being tracked, so this won't affect git operation, but adding .gitattributes here has the effect of it being added to the .npmignore file that npm pack/publish generate. This is desirable because otherwise any dependant project that chooses to commit their node_modules directroy to git is inheriting the developer's environment specific setting in this file. To turn the fun up to 11, the line endings in the published version of this project match the host environment of the publisher and are not convered to the the preferred normalized form configured in the .gitattributes file. So anyone installing and committing on Linux will get a nice screen of errors for all the CRLF files (including the .gitattributes file itself, which was a useful clue) being added to git.
michaelkourlas
added a commit
that referenced
this pull request
Dec 17, 2014
Add .gitattributes to .gitignore
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is already being tracked, so this won't affect git operation,
but adding .gitattributes here has the effect of it being added to the
.npmignore file that npm pack/publish generate. This is desirable
because otherwise any dependant project that chooses to commit their
node_modules directroy to git is inheriting the developer's environment
specific setting in this file.
To turn the fun up to 11, the line endings in the published version of
this project match the host environment of the publisher and are not
convered to the the preferred normalized form configured in the
.gitattributes file. So anyone installing and committing on Linux will
get a nice screen of errors for all the CRLF files (including the
.gitattributes file itself, which was a useful clue) being added to
git.
/cc @sam-github