Initialize context from middleware and not on get#18
Merged
michaelkrone merged 1 commit intomichaelkrone:masterfrom Jan 16, 2017
bookmd:fix-init-context
Merged
Initialize context from middleware and not on get#18michaelkrone merged 1 commit intomichaelkrone:masterfrom bookmd:fix-init-context
michaelkrone merged 1 commit intomichaelkrone:masterfrom
bookmd:fix-init-context
Conversation
Owner
|
@chenrozenes |
Contributor
Author
|
@michaelkrone I ran another test of mine that suddenly didn't work so I closed it until I'll figure it out, but all good |
Owner
|
OK, I will look into this tonight and publish a new version if it looks ok. |
Contributor
Author
|
@michaelkrone Hey, have you checked it out? |
Owner
|
Sorry for the delay. Will publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the entire express app inside a domain context, the
domain.activehas value.If we call
get/getContextfor the first time, it will initialize the___$cntxt___object before we created our request context domain.In this situation the middleware will not create another domain, and the outer domain will be used for all requests.
The problematic flow is this:
The fix will initialize the context object only within the middleware,
getandsetcalls will address the request-context domain only