Harden prepare-readme validation for em_/en_ symlinks on macOS#65
Merged
michen00 merged 3 commits into002-mnn-clipboard-en-emfrom Mar 30, 2026
Merged
Conversation
|
To use Codex here, create a Codex account and connect to github. |
Agent-Logs-Url: https://github.com/michen00/bin/sessions/a74ca88c-5f0b-4f1c-955b-6fc6e153baac Co-authored-by: michen00 <29467952+michen00@users.noreply.github.com>
Agent-Logs-Url: https://github.com/michen00/bin/sessions/a74ca88c-5f0b-4f1c-955b-6fc6e153baac Co-authored-by: michen00 <29467952+michen00@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address review comments for PR #51
Harden prepare-readme validation for Mar 30, 2026
em_/en_ symlinks on macOS
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the prepare-readme validation test to align README expectations with the symlink-aware em_/en_ behavior (and _mnn omission), and makes the test more reliable on macOS by bootstrapping to Bash 4.3+ when the default shell is too old.
Changes:
- Add a Bash 4.3+ re-exec bootstrap to
scripts/test-prepare-readme.shfor macOS/Homebrew environments. - Add explicit README contract assertions:
em_anden_must be documented;_mnnmust not be documented. - Adjust the test step labeling to reflect the expanded validation flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #51 already treats
em_anden_as symlinks to_mnn, but the prepare-readme path still had outdated assumptions around README expectations and could fail on macOS because Actions invoked it under Bash 3.2. This update narrows the fix to the validation path: keep the README contract aligned with symlink-aware behavior and make the prepare-readme test runnable under Bash 4.3+.README contract checks
README.mddocumentsem_anden_README.mddoes not document_mnnmacOS compatibility for prepare-readme CI
scripts/test-prepare-readme.sh< 4.3, re-exec under a newer Homebrew-installed Bash when available.github/scripts/validate-scripts.shon its required shell version without changing the underlying validation logicTargeted negative-path coverage
_mnn-based assumptionsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh auth status .pre-commit-config.yaml .gitattributes tests/update-mine.bats .scripts/concat_gitignores.sh .github/workflows/lint-github-actions.yml tests/_mnn.bats tests/venv-now.bats .vscode/extensions.json tests/chdirx.bats -o(http block)https://api.github.com/repos/agynio/gh-pr-review/releases/latest/usr/bin/gh gh extension install agynio/gh-pr-review lag=�� nv-_1cec1ut/overlay/bin/git nv-python3.12/bin/python nfig/composer/vendor/bin/bash s/CI.yml sh /node basename ts.s�� s k/bin/bin/tests/validate-scripts.bats(http block)If you need me to access, download, or install something from one of these locations, you can either:
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.