Apply a temporary fix to one of the dependencies and fix the grass_path block problem #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a dirty little hack to do this in the Dockerfile, but for now this means the end of my yak shaving.
bemk
changed the title
Owner
|
Hey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael.
From the patch file I deduce that you've run into the same issue as I have with this. I added a quick hack to the docker file fixing the fractions:gcd issue, which can remain in place so long as the up stream dependencies haven't been fixed.
Would you care to merge this change in for so long as this is the case?
I also added a change to support the rename of the grass_path block to dirt_path.
Thanks in advance!