Update Services examples #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pablogs9 merged 7 commits into foxy from feature/update_services_examples

Nov 25, 2020

Member

pablogs9 commented Nov 10, 2020 •

edited

Loading

Before merge:

Support for service clients rclc#44


          Update Services examples

528ce16

pablogs9 requested a review from jamoralp

November 10, 2020 09:47

pablogs9 mentioned this pull request

Support for service clients micro-ROS/rclc#44

Merged

1 task

JanStaschulat self-requested a review

November 10, 2020 16:25

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_client/main.c Outdated Show resolved Hide resolved

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_client/main.c Outdated Show resolved Hide resolved

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_client/main.c Show resolved Hide resolved

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_server/main.c Outdated Show resolved Hide resolved

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_server/main.c Show resolved Hide resolved

JanStaschulat reviewed

View reviewed changes

rclc/addtwoints_server/main.c Outdated Show resolved Hide resolved

JanStaschulat requested changes

View reviewed changes

Contributor

JanStaschulat left a comment

Initialization of service/client
const void pointer - first argument of client_callback
compiler warnings - unused arguments

pablogs9 and others added 6 commits

November 11, 2020 07:17


          Update rclc/addtwoints_client/main.c

2ac8da8

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>


          Update rclc/addtwoints_client/main.c

a723923

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>


          Update rclc/addtwoints_client/main.c

572f3d7

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>


          Update rclc/addtwoints_server/main.c

39ab744

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>


          Update rclc/addtwoints_server/main.c

2841ea5

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>


          Update

6cfde31

Member Author

pablogs9 commented Nov 11, 2020

All addressed

pablogs9 requested a review from JanStaschulat

November 11, 2020 06:26

JanStaschulat approved these changes

View reviewed changes

pablogs9 merged commit c5d19b3 into foxy

pablogs9 deleted the feature/update_services_examples branch

November 25, 2020 08:26

This was referenced Nov 25, 2020

Rework demos micro-ROS/freertos_apps#42

Merged

Rework demos #32

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet