-
Notifications
You must be signed in to change notification settings - Fork 68
Feature/foxy revision #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f125f50
First micro-ROS app on Linux reviewed.
FranFin d3faace
Reworking tutorials common sections.
FranFin 9a166fb
Significant changes in core tutori+zephyr_emulator tutorials.
FranFin 4557917
Changes reviewed.
FranFin 3e64c0a
First micro-ROS app tutorials migrated to foxy.
FranFin 29e9186
Comments addressed.
FranFin 1ad6bf1
Update _docs/tutorials/advanced/zephyr_emulator/index.md
pablogs9 e37f6aa
Update _docs/tutorials/core/first_application_rtos/zephyr.md
pablogs9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this branch be renamed or copied to include 'Foxy'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Ralph, we have been talking about how to manage the two different version
dashingandfoxy. Francesca has been testing both in order to ensure that everything works following the tutorial step by step, and I think that she has another branch with changes to dashing.So, what do you think about merging this tutorial in order to have the complete Foxy release (code + tutorials), and then we can work in integrating these Dashing tutorials tested by Francesca with some kind of "selector" where the user can switch between foxy and dashing version.
In a first review there are slightly differences between both: just the URL to code, some docker image names and these kind of things.
What do you think @FranFin @jamoralp?
PD: We have found some critical issues when using Dashing in 20.04 and Foxy in 18.04 because Ubuntu repos have updated Clang-tidy and GCC by some major version steps. So maybe I suggest that we should encourage the user to use the Ubuntu version according the ROS 2 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also leave this Zephyr/Zephyr emulator issue for the future. Let's discuss it in the first OFERA meeting and, if we deem it worth the change, we create a separate PR.