Fix native ethernet#37
Merged
Acuadros95 merged 2 commits intomicro-ROS:mainfrom Jul 11, 2022
fischejo:fix/native_ethernet
Merged
Fix native ethernet#37Acuadros95 merged 2 commits intomicro-ROS:mainfrom fischejo:fix/native_ethernet
Acuadros95 merged 2 commits intomicro-ROS:mainfrom
fischejo:fix/native_ethernet
Conversation
pablogs9
reviewed
Jul 11, 2022
Contributor
|
Please rebase onto main to fix CI |
The Teensy 4.1 requires a direct replacement for the normal Ethernet.h library by the NativeEthernet library. NativeEthernet is a builtin library in platformio, therefore no extra installations are required.
The locator struct is not handed over, but the transport_* callbacks depend on it. This result in a NULL pointer in `transport->args`.
pablogs9
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
board_microros_transport = native_ethernetfor the Teensy 4.1 doesn't work out of box. These two fixes are necessary.My setup: