Document memory_conf_t and memory_rule_t members#30
Merged
Acuadros95 merged 3 commits intomicro-ROS:galacticfrom May 13, 2022
Merged
Document memory_conf_t and memory_rule_t members#30Acuadros95 merged 3 commits intomicro-ROS:galacticfrom
Acuadros95 merged 3 commits intomicro-ROS:galacticfrom
Conversation
Acuadros95
reviewed
May 9, 2022
Contributor
|
Just a few comments, also adding @pablogs9 as a reviewer. |
pablogs9
approved these changes
May 9, 2022
Member
pablogs9
left a comment
There was a problem hiding this comment.
I'm OK with this if @Acuadros95 comments are added. Ping @gavanderhoorn
Contributor
Author
|
Friendly ping? |
Member
|
Please @gavanderhoorn could you add the requested changes? |
Contributor
Author
|
If you could take a look at my responses to your comments :) |
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Contributor
Author
|
I've just accepted your proposal, as I couldn't come up with a satisfying alternative phrasing. |
Acuadros95
approved these changes
May 13, 2022
Contributor
|
@mergify backport main |
mergify Bot
pushed a commit
that referenced
this pull request
May 13, 2022
* Document memory_conf_t and memory_rule_t members * Fix typo Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update include/micro_ros_utilities/type_utilities.h Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> (cherry picked from commit 3df7cf5)
Contributor
✅ Backports have been createdDetails
|
Acuadros95
pushed a commit
that referenced
this pull request
May 13, 2022
* Document memory_conf_t and memory_rule_t members * Fix typo Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> * Update include/micro_ros_utilities/type_utilities.h Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com> (cherry picked from commit 3df7cf5) Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
Contributor
Author
|
thanks |
Member
|
This seems to have break the CI in the API doc generator: https://github.com/micro-ROS/micro-ROS.github.io/runs/6465261539?check_suite_focus=true Can you take a look @Acuadros95 ? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per subject.
I've added some (very terse) documentation to the fields in
micro_ros_utilities_memory_rule_tandmicro_ros_utilities_memory_conf_t, as I kept having to go back to the Handling messages memory in micro-ROS page to see what the fields are for.Note: I'm not sure I understood the purpose of each of the fields completely -- or documented them correctly. The purpose of this PR is as much a way for me to get some confirmation.