Pass the MTU config from Zephyr to colcon #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiangeng Dong <dongjiangeng@gmail.com>
Contributor
|
LGMT. As a comment, you can send and receive messages longer than the MTU over reliable entities, chech this: docs |
Contributor
|
@mergify backport main foxy |
This was referenced Apr 20, 2022
Contributor
✅ Backports have been createdDetails
|
Acuadros95
added a commit
that referenced
this pull request
Apr 20, 2022
Pass the MTU config from Zephyr to colcon (backport #53)
Acuadros95
added a commit
that referenced
this pull request
Apr 20, 2022
Pass the MTU config from Zephyr to colcon (backport #53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Kconfig file, an MTU is defined. However, it is not passed to the Colcon build system, which means the MicroROS client always uses the default MTU, which is 512. This causes the publisher to always fail when sending a message larger than 500 bytes.
In this PR, one line is added to the makefile, so the
configured_colcon.metawill have the correct MTU set.Type of change
How Has This Been Tested?
uint32[256]) is published from anucleo-f746zgboard to a laptop. The MTU is set to 1036 in theprj.conf. It succeeds to get the message on the laptop withros2 topic echo.