Skip to content

Add external transport API#91

Merged
jamoralp merged 6 commits intofoxyfrom
feature/refactor_external_transports
Feb 9, 2021
Merged

Add external transport API#91
jamoralp merged 6 commits intofoxyfrom
feature/refactor_external_transports

Conversation

@pablogs9
Copy link
Copy Markdown
Member

@pablogs9 pablogs9 commented Jan 25, 2021 •
edited
Loading

TODO:

@pablogs9 pablogs9 mentioned this pull request Jan 25, 2021
Merged
5 tasks
@pablogs9 pablogs9 force-pushed the feature/refactor_external_transports branch from 71a78c2 to 2ece30f Compare January 25, 2021 14:33
@pablogs9 pablogs9 mentioned this pull request Jan 26, 2021
Merged
43 tasks
@pablogs9 pablogs9 requested a review from jamoralp January 26, 2021 15:01
@pablogs9 pablogs9 force-pushed the feature/refactor_external_transports branch 2 times, most recently from 7688b12 to d5acf17 Compare January 28, 2021 15:36
This was referenced Jan 29, 2021
Merged
Merged
Merged
Merged
@pablogs9
Copy link
Copy Markdown
Member Author

pablogs9 commented Feb 3, 2021

This PR should target foxy

@pablogs9 pablogs9 changed the base branch from main to foxy February 4, 2021 07:18
@pablogs9 pablogs9 force-pushed the feature/refactor_external_transports branch 2 times, most recently from 7c1daae to ebd15b6 Compare February 4, 2021 10:23
jamoralp
jamoralp reviewed Feb 5, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/include/rmw_uros/options.h
#define MAX_PORT_LEN 5
#define MAX_SERIAL_DEVICE 50

typedef struct rmw_uxrce_transport_params_t
Copy link
Copy Markdown
Contributor

@jamoralp jamoralp Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, this struct declaration fits ok here, but after I finish refactoring transports init/fini functions in a separate file (namely, transports.h) I could move it there. What do you think @pablogs9 ¿

Copy link
Copy Markdown
Member Author

@pablogs9 pablogs9 Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

jamoralp
jamoralp suggested changes Feb 8, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_init.c Outdated
pablogs9 and others added 3 commits February 9, 2021 11:31
@pablogs9
Initial
8e63a22 
Rename connection_params


Rename rmw_uxrce_connection_t


Update


Update


Update


Update


Update


Update


Update


Update


Update


Update


Update


Update tests


Update


Update


Update


Update


Fix warning


Fix warning


fix warning


Remove old approach
@pablogs9
Update
fe1ee6c
@pablogs9 @jamoralp
Update rmw_microxrcedds_c/src/rmw_init.c
ddad11e 
Co-authored-by: Jose Antonio Moral <joseantoniomoralparras@gmail.com>
@pablogs9 pablogs9 force-pushed the feature/refactor_external_transports branch from 5b3392b to ddad11e Compare February 9, 2021 10:32
@jamoralp jamoralp merged commit 2741bcf into foxy Feb 9, 2021
@jamoralp jamoralp deleted the feature/refactor_external_transports branch February 9, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamoralp jamoralp jamoralp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogs9 @jamoralp