Skip to content

Implement ping functionality from micro-ROS client to agent#94

Merged
pablogs9 merged 8 commits intofoxyfrom
feature/ping
Feb 9, 2021
Merged

Implement ping functionality from micro-ROS client to agent#94
pablogs9 merged 8 commits intofoxyfrom
feature/ping

Conversation

@jamoralp
Copy link
Copy Markdown
Contributor

@jamoralp jamoralp commented Feb 3, 2021

Mark as ready and trigger CI, when micro-ROS Agent docker includes new API for ping in this dockerhub build: https://hub.docker.com/repository/registry-1.docker.io/microros/micro-ros-agent/builds/7b011d45-84a3-4a54-9730-b8ba77dd2983

pablogs9
pablogs9 reviewed Feb 3, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_uros_options.c
pablogs9
pablogs9 reviewed Feb 3, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_uros_options.c Outdated
jamoralp
jamoralp commented Feb 3, 2021
View reviewed changes
Comment thread rmw_microxrcedds_c/src/rmw_uros_options.c Outdated
@jamoralp jamoralp mentioned this pull request Feb 8, 2021
Merged
43 tasks
@pablogs9 pablogs9 mentioned this pull request Feb 8, 2021
Merged
1 task
@jamoralp jamoralp marked this pull request as ready for review February 9, 2021 08:32
@jamoralp jamoralp changed the base branch from foxy to feature/refactor_external_transports February 9, 2021 08:33
pablogs9
pablogs9 previously approved these changes Feb 9, 2021
View reviewed changes
@jamoralp jamoralp mentioned this pull request Feb 9, 2021
Merged
@pablogs9 pablogs9 force-pushed the feature/refactor_external_transports branch from 5b3392b to ddad11e Compare February 9, 2021 10:32
Base automatically changed from feature/refactor_external_transports to foxy February 9, 2021 10:43
@jamoralp jamoralp dismissed pablogs9’s stale review February 9, 2021 10:43

The base branch was changed.

pablogs9 and others added 5 commits February 9, 2021 11:50
@pablogs9 @jamoralp
Initial
2b36b70 
Rename connection_params

Rename rmw_uxrce_connection_t

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update

Update tests

Update

Update

Update

Update

Fix warning

Fix warning

fix warning

Remove old approach
@pablogs9 @jamoralp
Update
169dc01
@jamoralp
Implement ping functionality from micro-ROS client to agent
593241e
@jamoralp
Refactor transport init/fini, external transport approach
d2f0278
@jamoralp
Change CI branch
dffe930
pablogs9
pablogs9 reviewed Feb 9, 2021
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
pablogs9
pablogs9 previously approved these changes Feb 9, 2021
View reviewed changes
@pablogs9 pablogs9 merged commit de75e0b into foxy Feb 9, 2021
@pablogs9 pablogs9 deleted the feature/ping branch February 9, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamoralp @pablogs9