Skip to content

Fixing flaky tests#71

Merged
norro merged 2 commits intomasterfrom
fix/launch-tests
Apr 8, 2021
Merged

Fixing flaky tests#71
norro merged 2 commits intomasterfrom
fix/launch-tests

Conversation

@norro
Copy link
Copy Markdown
Collaborator

@norro norro commented Apr 7, 2021

  • Fix flaky launch tests
  • Fix that processes sometimes don't react to SIGINT properly, leaving ugly error messages in the test procedure (not failing the testsm though)

#70

* Modes observer test now with less (redundant) spinning, but two sleeps
to wait for things to settle
* Modes observer test node now correctly reacting to SIGINT

#70

Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
@norro norro force-pushed the fix/launch-tests branch from 0c89ac9 to 6cc9234 Compare April 7, 2021 11:20
@norro norro self-assigned this Apr 7, 2021
@norro norro force-pushed the fix/launch-tests branch 6 times, most recently from 9280289 to ce311e3 Compare April 7, 2021 14:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2021

Codecov Report

Merging #71 (b7a24d9) into master (eeabfcb) will increase coverage by 6.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   21.08%   27.76%   +6.67%     
==========================================
  Files          14       14              
  Lines        1048     1048              
  Branches      754      754              
==========================================
+ Hits          221      291      +70     
+ Misses        524      280     -244     
- Partials      303      477     +174     
Impacted Files Coverage Δ
system_modes/src/system_modes/mode_impl.cpp 38.37% <0.00%> (+2.32%) ⬆️
system_modes/src/system_modes/mode_inference.cpp 35.69% <0.00%> (+5.44%) ⬆️
system_modes/src/system_modes/mode_observer.cpp 20.00% <0.00%> (+6.00%) ⬆️
system_modes/src/system_modes/mode_manager.cpp 16.54% <0.00%> (+16.16%) ⬆️
system_modes/include/system_modes/mode_manager.hpp 100.00% <0.00%> (+100.00%) ⬆️
...ystem_modes/include/system_modes/mode_handling.hpp 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeabfcb...b7a24d9. Read the comment docs.

@norro norro force-pushed the fix/launch-tests branch 4 times, most recently from 7c2562b to e1cdb70 Compare April 8, 2021 05:46
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
@norro norro force-pushed the fix/launch-tests branch from e1cdb70 to b7a24d9 Compare April 8, 2021 05:58
@norro norro merged commit 2dd9387 into master Apr 8, 2021
@norro norro deleted the fix/launch-tests branch April 8, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant