Skip to content

Comments

Fix trailing spaces/tabs in yaml syntax files#3200

Merged
JoeKar merged 1 commit intomicro-editor:masterfrom
dustdfg:fix/syntax-yaml-trailing-ws
Mar 22, 2024
Merged

Fix trailing spaces/tabs in yaml syntax files#3200
JoeKar merged 1 commit intomicro-editor:masterfrom
dustdfg:fix/syntax-yaml-trailing-ws

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Mar 20, 2024

No description provided.

- identifier: "\\b[A-Z_][0-9A-Z_]+\\b"
- identifier: "\\b[A-Z_][0-9A-Z_]+\\b"

##
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep has told me about a remaining trailing space at this line.

Copy link
Contributor Author

@dustdfg dustdfg Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tried and it told me about trailing space after ## which it true... But the reported by you space is one of the changes of commit. Are you sure you grepped on PR's branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the trailing spaces/tabs should be resolved with something like pre-commit hooks?

Copy link
Member

@JoeKar JoeKar Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the reported by you space is one of the changes of commit. Are you sure you grepped on PR's branch?

This is most probably caused by the scope of Github, but @dmaluka was most probably referring to line # 9.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I was referring to line 9.

Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg force-pushed the fix/syntax-yaml-trailing-ws branch from 00a4ef0 to 2aa7598 Compare March 22, 2024 04:39
@JoeKar JoeKar merged commit 426e6c6 into micro-editor:master Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants