Merged
Conversation
This was only needed to compile with Visual Studio 2010. It is no longer necessary with modern MSVC (doesn't do anything). Just in case, checked that the return value of snprintf() is not used (since it deffers from that of _snprintf()). It was only used by WOSM_rev.cpp, which is a recently added file (never built with old MSVC).
This is obsolete. Checked that the return value of snprintf() is not used (in fact, snprintf() is not used in the changed files).
Contributor
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was there to allow the code to compile with either Visual Studio 2010 or VS2015+.
It is no longer necessary or useful (we don't support compiling with anything older than VS2019), and currently has no effect.
Since people keep copy-pasting the inclusion of this file (even where
snprintf()is not used!), let's get rid of it for good.There is also often an adjacent
#include <Windows.h>that is cargo culted in many cases, but that is harder to mechanically remove because sometimes it is actually needed.No change to device interface.