MMDevice: Remove gettimeofday() for Windows#433
Merged
marktsuchida merged 1 commit intomainfrom Jan 22, 2024
Merged
Conversation
It is a bad idea to define functions named like POSIX standard ones, because other people can have the same idea and they can clash (we previously had this issue with Python < 3.7 and gettimeofday()). Fortunately no device adapter is currently using this function on Windows, so just remove the dead code. In modern C++, std::chrono offers better time functions for any new code that may need similar facilities. A few errors corrected in 3 device adapters that used definitions from Windows.h, which is no longer included (without WIN32_LEAN_AND_MEAN) by DeviceUtils.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bad idea to define functions named like POSIX standard ones, because other people can have the same idea and they can clash (we previously had this issue with Python < 3.7 and gettimeofday()).
Fortunately no device adapter is currently using this function on Windows, so just remove the dead code.
In modern C++, std::chrono offers better time functions for any new code that may need similar facilities.
A few errors corrected in 3 device adapters that used definitions from Windows.h, which is no longer included (without WIN32_LEAN_AND_MEAN) by DeviceUtils.h.