MMDevice: Delete most deprecated functions#710
Merged
marktsuchida merged 2 commits intomicro-manager:mainfrom Aug 15, 2025
Merged
MMDevice: Delete most deprecated functions#710marktsuchida merged 2 commits intomicro-manager:mainfrom
marktsuchida merged 2 commits intomicro-manager:mainfrom
Conversation
And remove corresponding CoreCallback implementations (and leftover functions from previously depeted ones).
5 tasks
This was referenced Aug 15, 2025
marktsuchida
added a commit
to marktsuchida/mmCoreAndDevices
that referenced
this pull request
Aug 16, 2025
In micro-manager#710 (0734eec) I changed the signature of one of the two overloads of InsertImage() from virtual int InsertImage( const Device* caller, const unsigned char* buf, unsigned width, unsigned height, unsigned byteDepth, const char* serializedMetadata, const bool doProcess = true) = 0; to virtual int InsertImage( const Device* caller, const unsigned char* buf, unsigned width, unsigned height, unsigned byteDepth, const char* serializedMetadata = nullptr, const bool doProcess = true) = 0; (added nullptr default argument to serializedMetadata). This was to support existing cameras that were calling the deleted overload MM_DEPRECATED( virtual int InsertImage( const Device* caller, const unsigned char* buf, unsigned width, unsigned height, unsigned byteDepth, const Metadata* md = 0, const bool doProcess = true)) = 0; without passing a non-null `md`. But I forgot to ensure that the called implementations in CoreCallback is checking for nullptr in this case (actually forgot to include the relevant commit). So here is a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove corresponding CoreCallback implementations (and leftover functions from previously deprecated ones).
Closes #295.
This leaves a few deprecated functions in MMDevice because they are still used by a few device adapters: