Bugfix: stop_headless raises AttributeError #808 #809
Merged
henrypinkard merged 2 commits intomicro-manager:mainfrom Mar 19, 2025
Merged
Bugfix: stop_headless raises AttributeError #808 #809henrypinkard merged 2 commits intomicro-manager:mainfrom
henrypinkard merged 2 commits intomicro-manager:mainfrom
Conversation
For Java backend (python_backend=False) the stop_headless method raises an AttributeError. Fixed by adding a check if Engine singleton has been initialized before trying to stop it.
Contributor
|
Great! and if you increment the version, it will automatically build an deploy to pypi |
Contributor
Author
|
Thanks for pointing that out! |
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #808:
For Java backend (
python_backend=False) thestop_headlessmethod raises anAttributeError.Fixed by adding a check if
Enginesingleton has been initialized before trying to stop it.