Skip to content

agent: finish delegated plan steps before returning success #3699

Description

@asim

Root cause:\nProvider-conformance run https://github.com/micro/go-micro/actions/runs/28607397226 failed atlascloud / plan-delegate. The conductor agent created the three required Design/Build/Ship tasks, but flow execution then failed with: agent run e2f025d2-d1be-49bf-b2ca-216912bb20d2 has unfinished plan steps: Delegate readiness notification to comms agent. In agent/agent.go, checkpointed runs are marked failed whenever unfinishedPlanSteps() is non-empty after the model reply. The live provider returned before executing the final delegated readiness-notification plan step, so the harness saw partial side effects (tasks created) and no completed delegation/notification.\n\nWhere:\n- agent/agent.go unfinished plan step validation for checkpointed runs\n- internal/harness/plan-delegate/main.go atlascloud plan-delegate harness prompt/flow\n\nAcceptance criteria:\n- The plan/delegate agent loop continues or otherwise recovers when required plan steps remain unfinished after an intermediate model reply, rather than returning success text with incomplete delegated work.\n- The conductor completes exactly one delegation to the comms agent and produces exactly one owner@acme.com notification after creating the three tasks.\n- Add or update a CI-safe test that exercises a model response sequence with an unfinished delegated plan step followed by completion.\n- With ATLASCLOUD_API_KEY/ATLASCLOUD_MODEL configured, this passes: go run ./internal/harness/provider-conformance -providers atlascloud -harnesses plan-delegate -summary-json provider-conformance-summary.json -summary-markdown provider-conformance-summary.md -capabilities-markdown provider-capabilities.md.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions