Implement NATS connection pooling and fix connection leaks #2840
+1,070
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NATS transport creates a new connection per
Dial()call, causing significant overhead in high-throughput RPC scenarios. Events and config components leak connections by discarding references after creation.Changes
Connection Pooling (broker/nats, transport/nats)
Added optional connection pooling with configurable size and idle timeout:
Default behavior unchanged: Pool size defaults to 1 (single persistent connection).
Implementation:
Connection Leak Fixes (events/natsjs, config/source/nats)
Connections created during initialization were never stored or closed:
Added
Close()method implementingio.Closerfor proper cleanup:Same pattern applied to config/source/nats.
Impact
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.