feat(client): add WithConnectionTimeout call option#2891
Merged
asim merged 1 commit intomicro:masterfrom Mar 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds WithConnectionTimeout(d time.Duration) CallOption to the client package, allowing callers to override the connection timeout on a per-call basis.
Why
The existing ConnectionTimeout(t time.Duration) Option sets the connection timeout at the client level (applies to all calls). There was no way to override this per-call, unlike other timeouts such as WithRequestTimeout or WithDialTimeout which already have their CallOption counterparts.
This follows the existing pattern where client-level options have a corresponding With* CallOption variant.