Skip to content

Harden AtlasCloud text tool-call parsing#4270

Merged
asim merged 1 commit into
masterfrom
codex/increment-4269
Jul 7, 2026
Merged

Harden AtlasCloud text tool-call parsing#4270
asim merged 1 commit into
masterfrom
codex/increment-4269

Conversation

@asim

@asim asim commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary:

  • Harden text-encoded tool-call parsing to accept HTML-escaped tagged markup and spaced tool/function/name attributes.
  • Add parser coverage for AtlasCloud/minimax delegate fallback formats.

Testing:

  • go build ./...
  • go test ./... (fails in this sandbox due loopback/network restrictions unrelated to this change: AtlasCloud stream test reached live endpoint without credentials; grpc loopback targets are blocked by the environment)
  • golangci-lint run ./...

Closes #4244
Closes #4269

@asim asim added the codex label Jul 7, 2026
Copilot AI review requested due to automatic review settings July 7, 2026 19:24
@asim asim added the codex label Jul 7, 2026
@asim asim merged commit 2c7b2db into master Jul 7, 2026
10 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the agent’s text-based tool-call fallback parser so AtlasCloud/minimax outputs that use HTML-escaped tagged markup and/or spaced name= / function= attributes are still recognized and executed when structured tool_calls are absent.

Changes:

  • Unescape HTML entities prior to parsing, enabling <tool_call ...>... formats to be detected.
  • Broaden tagged tool-call parsing to accept whitespace around function = ..., and centralize tool-name extraction via a regex that tolerates spacing/quoting variants.
  • Add focused unit tests covering spaced name = attributes and HTML-escaped <tool_call> markup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
agent/text_tool_calls.go Unescapes HTML before parsing; expands tagged tool-call/name parsing to handle spaced attributes robustly.
agent/text_tool_calls_test.go Adds regression tests for spaced name = attributes and HTML-escaped tagged tool-call markup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loop: build increment #123 atlascloud agent conformance must satisfy guarded delegation

3 participants