Harden AtlasCloud text tool-call parsing#4270
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the agent’s text-based tool-call fallback parser so AtlasCloud/minimax outputs that use HTML-escaped tagged markup and/or spaced name= / function= attributes are still recognized and executed when structured tool_calls are absent.
Changes:
- Unescape HTML entities prior to parsing, enabling
<tool_call ...>...formats to be detected. - Broaden tagged tool-call parsing to accept whitespace around
function = ..., and centralize tool-name extraction via a regex that tolerates spacing/quoting variants. - Add focused unit tests covering spaced
name =attributes and HTML-escaped<tool_call>markup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
agent/text_tool_calls.go |
Unescapes HTML before parsing; expands tagged tool-call/name parsing to handle spaced attributes robustly. |
agent/text_tool_calls_test.go |
Adds regression tests for spaced name = attributes and HTML-escaped tagged tool-call markup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing:
Closes #4244
Closes #4269