Split search into local/web, add admin log/env pages, instrument Brave API#159
Merged
Split search into local/web, add admin log/env pages, instrument Brave API#159
Conversation
Co-authored-by: asim <17530+asim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add logging for Brave API errors and system log access
Split search into local/web, add admin log/env pages, instrument Brave API
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brave API errors were silently swallowed with no visibility,
/searchconflated free local search with paid web search, and there was no admin tooling to inspect system state.Search separation
/search— local data index only, free, no auth required (sidebar form unchanged)/web— Brave-powered web search, auth + wallet quota requiredBrave API observability
searchBrave()now callsapp.RecordAPICall()on every outcome — errors, non-200 responses, and successes all appear in/admin/apiwith status code, duration, and response body.New admin pages (all require admin auth)
/admin/log— in-memory ring buffer (500 entries) of allapp.Log()output, newest first/admin/env— shows which known env vars are set with character count; values never exposedSupporting changes
app/syslog.go: ring buffer wired intoapp.Log()viaappendSysLog()video/video.go: fixed latentgo vetviolation —app.Logcall passingerrarg with no format verb🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.