Include README and LICENSE in published package; fix stale branch refs#130
Merged
microbit-matt-hillsdon merged 3 commits intoappsfrom Apr 28, 2026
Merged
Include README and LICENSE in published package; fix stale branch refs#130microbit-matt-hillsdon merged 3 commits intoappsfrom
microbit-matt-hillsdon merged 3 commits intoappsfrom
Conversation
Contributor
microbit-matt-hillsdon
commented
Apr 28, 2026
microbit-matt-hillsdon
commented
- Add prepack/postpack to copy README.md and LICENSE from the repo root into packages/microbit-connection so they ship in the npm tarball.
- Fix reference to LICENCE.md from the package.json file.
- Update README migration-guide URL from the apps branch to main. This doesn't work until we merge back but getting it in place now.
- Tweek time-bound CreateAI sentence in the V1-no-DFU-service note.
- Update MIGRATION.md.
- Add prepack/postpack to copy README.md and LICENSE from the repo root into packages/microbit-connection so they ship in the npm tarball. - Fix reference to LICENCE.md from the package.json file. - Update README migration-guide URL from the apps branch to main. This doesn't work until we merge back but getting it in place now. - Tweek time-bound CreateAI sentence in the V1-no-DFU-service note. - Update MIGRATION.md.
Deploying microbit-connection with
|
| Latest commit: |
f5479b6
|
| Status: | 🚫 Build failed. |
- Hardcode links for typedoc (main) - Fix cross-module typedoc links and AbortSignal isn't ours
microbit-grace
approved these changes
Apr 28, 2026
Contributor
microbit-grace
left a comment
microbit-grace
left a comment
There was a problem hiding this comment.
Added a question and a suggestion, otherwise LGTM
Comment on lines
+73
to
+74
| "prepack": "cp ../../README.md ../../LICENSE.md .", | ||
| "postpack": "rm -f README.md LICENSE.md" |
Contributor
There was a problem hiding this comment.
Where are these used?
Contributor
Author
There was a problem hiding this comment.
By npm pack. The monorepo restructure means we need to grab the root ones for the package build as it doesn't have its own readme.
Closed
Co-authored-by: Grace <145345672+microbit-grace@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.