Skip to content

Format the whole repo with prettier#132

Merged
microbit-matt-hillsdon merged 2 commits intoappsfrom
format
Apr 28, 2026
Merged

Format the whole repo with prettier#132
microbit-matt-hillsdon merged 2 commits intoappsfrom
format

Conversation

@microbit-matt-hillsdon
Copy link
Copy Markdown
Contributor

The format/format:check scripts only checked packages/*/src, so apps/ and root markdown drifted out of style. Widen the glob to "." with a .prettierignore that skips node_modules, build output, Capacitor native projects, hex files and the lockfile.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 28, 2026

Deploying microbit-connection with  Cloudflare Pages  Cloudflare Pages

Latest commit: 80f56f4
Status:🚫  Build failed.

View logs

Copy link
Copy Markdown
Contributor

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much prettier

The format/format:check scripts only checked packages/*/src, so apps/
and root markdown drifted out of style. Widen the glob to "." with a
.prettierignore that skips node_modules, build output, Capacitor
native projects, hex files and the lockfile.
The versioner action rewrites packages/microbit-connection/package.json
to set the version, and its output isn't prettier-formatted, so
format:check fails in CI even when the committed file is clean locally.
@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 27b9200 into apps Apr 28, 2026
3 of 4 checks passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the format branch April 28, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants