`i2c.init()` doesn't change the pins

[microbit-carlos]

micropython-microbit-v2/src/codal_app/microbithal.cpp

Lines 205 to 212 in f3db1e6

	int microbit_hal_i2c_init(int scl, int sda, int freq) {
	// TODO set pins
	int ret = uBit.i2c.setFrequency(freq);
	if (ret != DEVICE_OK) {
	return ret;;
	}
	return 0;
	}

@dpgeorge if this is something that needs implementing in CODAL let me know, or feel free to open an issue in https://github.com/lancaster-university/codal-microbit-v2/issues

[dpgeorge]

Some functions in the CODAL to change the I2C pins would be good. Then it would be similar to SPI.

[microbit-carlos]

Created this for I2C:

• Method to change I2C and SPI pins lancaster-university/codal-microbit-v2#226

Some functions in the CODAL to change the I2C pins would be good. Then it would be similar to SPI.

Does CODAL offer a way to change the SPI pins after the object has been created?

• https://github.com/lancaster-university/codal-core/blob/master/inc/driver-models/SPI.h
• https://github.com/lancaster-university/codal-nrf52/blob/d54752690753ef8377d38f0338b9fcac9f60655d/inc/NRF52SPI.h

Does MicroPython need the SPI classes to be updated as well?

[microbit-carlos]

Does MicroPython need the SPI classes to be updated as well?

Ah, okay, just saw the response in #111 (comment), and based on that I've updated the ticket lancaster-university/codal-microbit-v2#226 to include SPI as well as I2C.

[microbit-carlos]

The CODAL changes required spawn several repos and files, so to reduce risk for the v2.1.0 final release we'll do this for v2.2.

[microbit-carlos]

CODAL has been updated with the redirect() methods and this can be implemented using the latest tag (0.2.48 at the time of writing).

[dpgeorge]

CODAL was updated to 0.2.48 and i2c.init() pin change implemented in ee75741

I noticed a bug though: if you try to redirect to pins that are already claimed by I2C then it locks up. Eg:

i2c.init(100000, pin0, pin1)  # works fine
i2c.init(100000, pin1, pin0)  # locks up if the previous line is run first

I suspect that's a bug in CODAL but did not get to the bottom of it.

[microbit-carlos]

Thanks Damien, I've opened this issue in the CODAL repo:

• I2C redirect twice freezes the micro:bit lancaster-university/codal-microbit-v2#272

[finneyj]

Thanks @dpgeorge @microbit-carlos - indeed, precisely as you say. I can reproduce too.

This should now be fixed in the CODAL master branch, pending next release:
lancaster-university/codal-microbit-v2#272

Please let me know if you notice this or any other similar issues.