Skip to content

Increase session button focus visible indicator outline #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Increase session button focus visible indicator outline #518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9936711
Increase session button focus visible indicator outline
microbit-robert Nov 18, 2024
bfc291b
Stateless implementation
microbit-robert Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 53 additions & 46 deletions src/components/NewPageChoice.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,52 +30,59 @@ const NewPageChoice = ({
}
}, [disabled, onClick]);
return (
<HStack
flex="1"
spacing={0}
boxShadow="lg"
borderRadius="md"
bgColor="white"
onClick={handleClick}
cursor="pointer"
alignItems="stretch"
opacity={disabled ? 0.5 : undefined}
userSelect={disabled ? "none" : undefined}
_hover={{
bgColor: disabled ? undefined : "brand.50",
}}
role="group"
{...props}
>
<Stack as="section" py={5} px={5} minH={40} flex="1 1 auto">
<Heading as="h3" fontSize="xl">
{label}
</Heading>
{children}
</Stack>
<Box>
<IconButton
w={40}
isDisabled={disabled}
aria-label={label}
bgColor="brand.700"
color="white"
height="100%"
variant="unstyled"
icon={icon}
borderInlineEndRadius="md"
_groupHover={{
color: disabled ? undefined : "#efedf5",
}}
_hover={{
bgColor: "brand.700",
}}
_disabled={{
opacity: 1,
}}
/>
</Box>
</HStack>
<Box boxShadow="lg" flex="1" role="group">
<HStack
spacing={0}
borderRadius="md"
bgColor="white"
onClick={handleClick}
cursor="pointer"
alignItems="stretch"
opacity={disabled ? 0.5 : undefined}
userSelect={disabled ? "none" : undefined}
transitionDuration="200ms"
transitionProperty="background-color"
_hover={{
bgColor: disabled ? undefined : "brand.50",
}}
_groupFocusWithin={{
boxShadow: "outline",
}}
{...props}
>
<Stack as="section" py={5} px={5} minH={40} flex="1 1 auto">
<Heading as="h3" fontSize="xl">
{label}
</Heading>
{children}
</Stack>
<Box>
<IconButton
w={40}
isDisabled={disabled}
aria-label={label}
bgColor="brand.700"
color="white"
height="100%"
variant="unstyled"
icon={icon}
borderInlineEndRadius="md"
_groupHover={{
color: disabled ? undefined : "#efedf5",
}}
_focusVisible={{
boxShadow: "none",
}}
_hover={{
bgColor: "brand.700",
}}
_disabled={{
opacity: 1,
}}
/>
</Box>
</HStack>
</Box>
);
};

Expand Down
Loading